Skip to content

Update repositories.txt #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Update repositories.txt #1156

merged 1 commit into from
Mar 7, 2022

Conversation

InfiniteCoder01
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

A problem was found with your submission https://github.com/InfiniteCoder01/BufferedOreonSSD1351

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @InfiniteCoder01
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Mar 6, 2022
@per1234
Copy link
Contributor

per1234 commented Mar 6, 2022

Hello @InfiniteCoder01. Thanks for your interest in contributing to the Arduino Library Manager index!

I see the bot reported a problem with your submission that will block its acceptance:

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

If you have any questions or problems while following the instructions to resolve the problem, please let me know and I'll help out.

If you decide you no longer wish to submit the library, you can close this pull request.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Mar 6, 2022
@InfiniteCoder01
Copy link
Contributor Author

Fixed

@per1234
Copy link
Contributor

per1234 commented Mar 7, 2022

Hello @InfiniteCoder01. I see the repository still does not have any tags or releases:

https://github.com/InfiniteCoder01/BufferedOreonSSD1351/tags

Did you maybe forget to push the tag from your local clone of the repository to GitHub?

@InfiniteCoder01
Copy link
Contributor Author

Fixed now

@per1234
Copy link
Contributor

per1234 commented Mar 7, 2022

@ArduinoBot please check it again.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/InfiniteCoder01/BufferedOreonSSD1351:

Linting library in BufferedOreonSSD1351
INFO: No header file found matching library name (Buffered_Oreon_SSD1351.h). Best practices are for primary header      
      filename to match library name. (Rule LS008)                                                                      
WARNING: library.properties name value Buffered Oreon SSD1351 is longer than the recommended length of 16 characters.   
         (Rule LP010)                                                                                                   
WARNING: library.properties name Buffered Oreon SSD1351 contains spaces. Although supported, best practices is to not   
         use spaces. (Rule LP015)                                                                                       
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed. (Rule LP036)                                                                                    

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in BufferedOreonSSD1351/examples/test

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 85e7070 into arduino:main Mar 7, 2022
github-actions bot pushed a commit that referenced this pull request Mar 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/InfiniteCoder01/BufferedOreonSSD1351/

@InfiniteCoder01 InfiniteCoder01 deleted the patch-1 branch March 7, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants