Skip to content

added serial lcd #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2022
Merged

added serial lcd #1258

merged 1 commit into from
Apr 3, 2022

Conversation

An7orAhmed
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

A problem was found with your submission https://github.com/AntorOfficial/LiquidCrystalSerial

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @AntorOfficial
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@An7orAhmed An7orAhmed closed this Apr 3, 2022
@An7orAhmed An7orAhmed reopened this Apr 3, 2022
@per1234
Copy link
Contributor

per1234 commented Apr 3, 2022

@ArduinoBot please check it again.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/AntorOfficial/LiquidCrystalSerial:

Linting library in LiquidCrystalSerial
WARNING: library.properties name value LiquidCrystalSerial is longer than the recommended length of 16 characters. (Rule
         LP010)                                                                                                         
WARNING: No license file found. See:                                                                                                                  
         https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license
         (Rule LD002)                                                                                                                                 

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in LiquidCrystalSerial/examples/HelloWorld

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit a4c539b into arduino:main Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/AntorOfficial/LiquidCrystalSerial/

github-actions bot pushed a commit that referenced this pull request Apr 3, 2022
@per1234 per1234 self-assigned this Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants