Skip to content

Add library for PT6312 VFD controllers #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

ysard
Copy link
Contributor

@ysard ysard commented Apr 9, 2022

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

A problem was found with your submission https://github.com/ysard/PT6312_VFD_Arduino_Library

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Apr 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @ysard
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Apr 10, 2022

Hello @ysard. Thanks for your interest in contributing to the Arduino Library Manager index.

I see the bot reported a problem with your submission that will block its acceptance:

The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

If you have any questions or problems while following the instructions to resolve the problem, please let me know and I'll help out.

If you decide you no longer wish to submit the library, you can close this pull request.

@per1234 per1234 self-assigned this Apr 10, 2022
@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Apr 10, 2022
@ysard
Copy link
Contributor Author

ysard commented Apr 11, 2022

Hello, thank you for your prompt help;
I was missing some commits to realize on the project. It's done now :)

@ysard
Copy link
Contributor Author

ysard commented Apr 11, 2022

@ArduinoBot : done

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Apr 11, 2022
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/ysard/PT6312_VFD_Arduino_Library:

Linting library in PT6312_VFD_Arduino_Library
WARNING: Unable to load the library.properties url field: 404 Not Found (Rule LP042)

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in PT6312_VFD_Arduino_Library/examples/test_attiny_vfd

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 April 11, 2022 01:24
Conflicts:
	repositories.txt
@github-actions github-actions bot removed the request for review from per1234 April 11, 2022 01:32
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/ysard/PT6312_VFD_Arduino_Library:

Linting library in PT6312_VFD_Arduino_Library
WARNING: Unable to load the library.properties url field: 404 Not Found (Rule LP042)

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in PT6312_VFD_Arduino_Library/examples/test_attiny_vfd

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit bd015dc into arduino:main Apr 11, 2022
github-actions bot pushed a commit that referenced this pull request Apr 11, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/ysard/PT6312_VFD_Arduino_Library/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants