Skip to content

Update repositories.txt #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

Update repositories.txt #1359

merged 1 commit into from
May 5, 2022

Conversation

MaximeLBG
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

A problem was found with your submission https://github.com/MaximeLBG/CV7OEMFR

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions github-actions bot added the topic: submission Add library to the list label May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @MaximeLBG
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented May 5, 2022

@MaximeLBG
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
⚠️ PLEASE READ THIS IMPORTANT INFORMATION ⚠️
⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️
❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗❗
@MaximeLBG

Hello @MaximeLBG. As I mentioned in your previous pull request (#1355 (comment)), you had fixed the error reported by the bot yesterday. However, Library Manager works exclusively from Git tags, so the bot wasn't able to see the fix you made. It doesn't see the changes you make until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/MaximeLBG/CV7OEMFR/tree/v3.1.2

I see that you have now regressed the library back to having the problem once more, so you will need to move the library back to the root of the repository, as required for acceptance to the Arduino Library Manager index:

https://github.com/arduino/library-registry/blob/main/FAQ.md#what-are-the-requirements-for-a-library-to-be-added-to-library-manager

After that, make a new release or tag in the library repository.

Finally, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager. There is no need to continue to submit redundant pull requests and this only makes it more difficult for us to carry on a conversation (unlike the ArduinoBot, I am a human, so we can do that).

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 mentioned this pull request May 5, 2022
@MaximeLBG
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/MaximeLBG/CV7OEMFR:

Linting library in CV7OEMFR
WARNING: Missing category field in library.properties. See                                                              
         https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format (Rule LP037) 
WARNING: No license file found. See:                                                                                                                  
         https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license
         (Rule LD002)                                                                                                                                 

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in CV7OEMFR/examples/CV7OEMFR

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit def752a into arduino:main May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/MaximeLBG/CV7OEMFR/

github-actions bot pushed a commit that referenced this pull request May 5, 2022
@per1234 per1234 mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants