Skip to content

Update repositories.txt #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Update repositories.txt #1808

merged 1 commit into from
Sep 5, 2022

Conversation

dnzayan
Copy link
Contributor

@dnzayan dnzayan commented Sep 5, 2022

https://github.com/dnzayan/ESP32_Pinoo

Library will be added to the Arduino Library Manager.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

A problem was found with your submission https://github.com/dnzayan/ESP32_Pinoo

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @dnzayan
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dnzayan
Copy link
Contributor Author

dnzayan commented Sep 5, 2022

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

ERROR: Arduino Lint found errors with https://github.com/dnzayan/ESP32_Pinoo:

Linting library in ESP32_Pinoo
INFO: No header file found matching library name (ESP32_Pinoo.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: library.properties depends field item(s) Firebase_Arduino_Client_Library_for_ESP8266_and_ESP32 (2.3.7) have      
       invalid constraint syntax.                                                                                       
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP058)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in ESP32_Pinoo/examples/01-SendingButtonValue

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Thanks for your interest in contributing to the Arduino Library Manager index @dnzayan
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dnzayan
Copy link
Contributor Author

dnzayan commented Sep 5, 2022

@ArduinoBot

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Arduino Lint has suggestions for possible improvements to https://github.com/dnzayan/ESP32_Pinoo:

Linting library in ESP32_Pinoo
WARNING: library.properties depends field item(s) Firebase_Arduino_Client_Library_for_ESP8266_and_ESP32 (=2.3.7) not    
         found in the Library Manager index.                                                                            
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP048)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ESP32_Pinoo/examples/01-SendingButtonValue

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit bd42aa2 into arduino:main Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/dnzayan/ESP32_Pinoo/

github-actions bot pushed a commit that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant