Skip to content

New library marisa-esp32 #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

New library marisa-esp32 #1896

merged 1 commit into from
Sep 23, 2022

Conversation

siara-cc
Copy link
Contributor

Please include marisa-esp32 to library registry!!

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/siara-cc/marisa-esp32

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 23, 2022
@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @siara-cc
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@siara-cc
Copy link
Contributor Author

@ArduinoBot I fixed the issue. Please re-run the checks.

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/siara-cc/marisa-esp32:

Linting library in marisa-esp32
INFO: No header file found matching library name (Marisa_ESP32_Wrapper.h). Best practices are for primary header        
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Marisa ESP32 Wrapper is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format    
         (Rule LP010)                                                                                              
WARNING: library.properties name Marisa ESP32 Wrapper contains spaces. Although supported, best practices is to not use 
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in marisa-esp32/examples/lookup_word_phrase

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 6824c2d into arduino:main Sep 23, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/siara-cc/marisa-esp32/

github-actions bot pushed a commit that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant