Skip to content

Add OWire LED Library #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Add OWire LED Library #1903

merged 1 commit into from
Sep 25, 2022

Conversation

NPoole
Copy link
Contributor

@NPoole NPoole commented Sep 25, 2022

No description provided.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/sparkfun/SparkFun_OWire_Arduino_Library

ERROR: Unable to load submission URL. Is the repository public?

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 25, 2022
@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @NPoole
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@NPoole
Copy link
Contributor Author

NPoole commented Sep 25, 2022

Sorry @ArduinoBot, forgot to make public

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/sparkfun/SparkFun_OWire_Arduino_Library:

Linting library in SparkFun_OWire_Arduino_Library
WARNING: library.properties name value SparkFun OWire Arduino Library is longer than the recommended length of 16       
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
WARNING: Library name SparkFun OWire Arduino Library contains "Arduino". This is superfluous.                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
WARNING: library.properties name SparkFun OWire Arduino Library contains spaces. Although supported, best practices is  
         to not use spaces.                                                                                             
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name SparkFun OWire Arduino Library contains "library". This is superfluous.                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 5 WARNINGS

-------------------

Linting sketch in SparkFun_OWire_Arduino_Library/examples/Example1-TheBasics

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@github-actions github-actions bot merged commit 120b2aa into arduino:main Sep 25, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/sparkfun/SparkFun_OWire_Arduino_Library/

github-actions bot pushed a commit that referenced this pull request Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant