Skip to content

Added a new library #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Added a new library #1972

merged 1 commit into from
Oct 12, 2022

Conversation

gvandersel
Copy link
Contributor

Library for controlling a selectrix controlled modellayout

@github-actions github-actions bot added the topic: modification Change existing list entry label Oct 12, 2022
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/gvandersel/SXArduino

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

Hi @gvandersel.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @gvandersel
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 October 12, 2022 11:50
@gvandersel
Copy link
Contributor Author

Tag added @ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Hi @gvandersel.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the request for review from per1234 October 12, 2022 12:00
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/gvandersel/SXArduino:

Linting library in SXArduino
WARNING: Library name SXArduino contains "Arduino". This is superfluous.                                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
ERROR: Library name SXArduino not found in the Library Manager index. Library names are not allowed to change after     
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: library.properties version value 3.2 is not compliant with the semver specification.
         See: https://semver.org/                                                            
         (Rule LP021)                                                                        
WARNING: Sketch(es) found outside examples and extras folders:                                    
           SXArduino/Examples/EmptySXaccessoire                                                   
           SXArduino/Examples/SXOccupianceDetektor                                                
           SXArduino/Examples/SXOccupianceDetektor/EEOccupianceDetektor                           
           SXArduino/Examples/SXinterface                                                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             
WARNING: Potentially misspelled examples folder name found: SXArduino/Examples                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             
WARNING: Incorrect examples folder name case: SXArduino/Examples                                  
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD006)                                                                             

Linter results for project: 1 ERRORS, 6 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @gvandersel
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 October 12, 2022 12:01
Library for controlling a selectrix controlled modellayout
@github-actions github-actions bot added topic: submission Add library to the list and removed topic: modification Change existing list entry labels Oct 12, 2022
@github-actions github-actions bot removed the request for review from per1234 October 12, 2022 15:07
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/gvandersel/SXArduino:

Linting library in SXAccessoire
WARNING: library.properties version value 3.2 is not compliant with the semver specification.
         See: https://semver.org/                                                            
         (Rule LP021)                                                                        

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in SXAccessoire/examples/EmptySXaccessoire

Linter results for project: no errors or warnings

-------------------

Linting sketch in SXAccessoire/examples/SXOccupianceDetektor

Linter results for project: no errors or warnings

-------------------

Linting sketch in SXAccessoire/examples/SXinterface

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 334a050 into arduino:main Oct 12, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/gvandersel/SXAccessoire/

github-actions bot pushed a commit that referenced this pull request Oct 12, 2022
@per1234 per1234 self-assigned this Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants