Skip to content

Update repositories.txt #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Update repositories.txt #2300

merged 1 commit into from
Dec 23, 2022

Conversation

Ebola-Chan-bot
Copy link
Contributor

@Ebola-Chan-bot Ebola-Chan-bot commented Dec 23, 2022

Add Arduino-STL-2. This library is based on the existing ArduinoSTL, whose author has no activities for quite a long time.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 23, 2022
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/Silver-Fang/ArduinoSTL:

Linting library in ArduinoSTL
INFO: No header file found matching library name (Arduino-STL-2.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Library name Arduino-STL-2 starts with "Arduino". These names are reserved for official libraries.    
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP012)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @silver-fang
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@Ebola-Chan-bot
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/Silver-Fang/ArduinoSTL:

Linting library in ArduinoSTL
INFO: No header file found matching library name (STL_for_Arduino.h). Best practices are for primary header filename to 
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Library name STL for Arduino contains "Arduino". This is superfluous.                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          
WARNING: library.properties name STL for Arduino contains spaces. Although supported, best practices is to not use      
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in ArduinoSTL/examples/CinAndCout

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 7ad2a0c into arduino:main Dec 23, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/Silver-Fang/ArduinoSTL/

github-actions bot pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant