Skip to content

Update repositories.txt #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Update repositories.txt #237

merged 1 commit into from
Jul 19, 2021

Conversation

SergeSkor
Copy link
Contributor

@SergeSkor SergeSkor commented Jul 19, 2021

No description provided.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/SergeSkor/SSVTimer:

Linting library in SSVTimer
Rule LP031 result: fail
ERROR: Missing sentence field in library.properties. See https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
Rule LD002 result: fail
WARNING: No license file found. See: https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license

Finished linting project. Results:
Warning count: 1
Error count: 1
Rules passed: false

-------------------

Linting sketch in SSVTimer/examples/SSVTimer_Test

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 1
Error count: 1
Rules passed: false

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @SergeSkor
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Jul 19, 2021

Hi @SergeSkor. I see you have resolved the error of the missing sentence field in library.properties. However, Library Manager works exclusively from Git tags, so it can't see the changes made to your repository after the latest tag. You can see that at the time of the latest tag the library.properties file was still missing its sentence field:
https://github.com/SergeSkor/SSVTimer/blob/v1.0.0/library.properties

So you now need to do three things:

  1. Update the version field in library.properties (e.g., 1.0.1)
  2. Create a release or tag in the repository.
  3. Make a comment here, mentioning the bot.

When there are problems with a submission, there is no need to make a new pull request over and over. Simply comment with the bot's name and it will run the checks again. As soon as the library passes all the checks, the pull request will be merged and your library added to Library Manager.

Please let me know if you have any questions or problems.
Regards, Per

@per1234 per1234 mentioned this pull request Jul 19, 2021
@SergeSkor
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/SergeSkor/SSVTimer:

Linting library in SSVTimer
Rule LD002 result: fail
WARNING: No license file found. See: https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license

Finished linting project. Results:
Warning count: 1
Error count: 0
Rules passed: true

-------------------

Linting sketch in SSVTimer/examples/SSVTimer_Test

Finished linting project. Results:
Warning count: 0
Error count: 0
Rules passed: true

-------------------

Finished linting projects. Results:
Warning count: 1
Error count: 0
Rules passed: true

@github-actions github-actions bot merged commit 68adb1f into arduino:main Jul 19, 2021
github-actions bot pushed a commit that referenced this pull request Jul 19, 2021
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/SergeSkor/SSVTimer/

@rsora rsora added the topic: submission Add library to the list label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants