Skip to content

Update repositories.txt #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

tadfmac
Copy link
Contributor

@tadfmac tadfmac commented Jan 14, 2023

Hello.

I created a library to addition simple MIDI comminucation to ch55xduino core.
Could you add this to a list of libraries?

url: https://github.com/mimuz/mimuz-ch55x

Thanks.

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 14, 2023
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/mimuz/mimuz-ch55x:

Linting library in mimuz-ch55x
INFO: No header file found matching library name (mi_muz_for_ch55xduino.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value mi:muz for ch55xduino is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format     
         (Rule LP010)                                                                                               
ERROR: Prohibited character(s) in library.properties name value: mi:muz for ch55xduino                       
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name mi:muz for ch55xduino contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in mimuz-ch55x/examples/midi-callback

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @tadfmac
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@tadfmac
Copy link
Contributor Author

tadfmac commented Jan 14, 2023

@ArduinoBot Thanks for your checking! I fixed it!

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit ce15a7b into arduino:main Jan 14, 2023
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/mimuz/mimuz-ch55x/

github-actions bot pushed a commit that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant