Skip to content

Add PicoDVI - Adafruit Fork #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Add PicoDVI - Adafruit Fork #2555

merged 1 commit into from
Mar 9, 2023

Conversation

PaintYourDragon
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

ERROR: Arduino Lint found errors with https://github.com/adafruit/PicoDVI:

Linting library in PicoDVI
ERROR: Symlink(s) found. Symlinks cause difficulties for Windows users. These block addition to the Arduino Library     
       Manager index:                                                                                                   
         PicoDVI/src/libdvi                                                                                             
       (Rule LS005)                                                                                                     
INFO: No header file found matching library name (PicoDVI_-_Adafruit_Fork.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value PicoDVI - Adafruit Fork is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name PicoDVI - Adafruit Fork contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in PicoDVI/examples/16bit_hello

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/1bit_double_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/1bit_single_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/1bit_text

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/8bit_double_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/8bit_single_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/virtual_spitft

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @PaintYourDragon
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@PaintYourDragon
Copy link
Contributor Author

@ArduinoBot fixed now?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/adafruit/PicoDVI:

Linting library in PicoDVI
INFO: No header file found matching library name (PicoDVI_-_Adafruit_Fork.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value PicoDVI - Adafruit Fork is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name PicoDVI - Adafruit Fork contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in PicoDVI/examples/16bit_hello

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/1bit_double_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/1bit_single_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/1bit_text

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/8bit_double_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/8bit_single_buffer

Linter results for project: no errors or warnings

-------------------

Linting sketch in PicoDVI/examples/virtual_spitft

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 8e6b23e into arduino:main Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/adafruit/PicoDVI/

github-actions bot pushed a commit that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant