Skip to content

Update repositories.txt #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RobertByrnes
Copy link
Contributor

Please add this lib to Arduino, thank you 💯

@github-actions github-actions bot added the topic: submission Add library to the list label Jul 25, 2023
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/govorox/SSLClient:

Linting library in SSLClient
ERROR: Library name SSLClient is in use by a library in the Library Manager index. Each library must have a unique name 
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in SSLClient/examples/Esp32/https_eth_LilyGo-T-ETH-POE

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/https_gsm_SIM7000

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/https_gsm_SIM7600/https_get_sim7600

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/https_gsm_SIM7600/https_post_sim7600

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/https_gsm_SIM800

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/https_wifi

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/mqtt_gsm_SIM800L_Azure_x509_Device_Twin

Linter results for project: no errors or warnings

-------------------

Linting sketch in SSLClient/examples/Esp32/mqtt_secure_gsm_SIM7000

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @RobertByrnes
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Jul 26, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @RobertByrnes. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/govorox/SSLClient/blob/1.1.0/library.properties#L1

name=SSLClient

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jul 26, 2023
@RobertByrnes
Copy link
Contributor Author

@ArduinoBot The requested change is now there

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot requested a review from per1234 July 26, 2023 07:34
@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Jul 26, 2023
@github-actions github-actions bot removed the request for review from per1234 July 26, 2023 07:35
@github-actions github-actions bot merged commit 99b9922 into arduino:main Jul 26, 2023
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/govorox/SSLClient/

github-actions bot pushed a commit that referenced this pull request Jul 26, 2023
@RobertByrnes RobertByrnes deleted the RobertByrnes-govorox/SSLClient branch July 26, 2023 07:36
@RobertByrnes
Copy link
Contributor Author

@ArduinoBot

@per1234
Copy link
Contributor

per1234 commented Aug 1, 2023

Hello @RobertByrnes. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.

But this human is happy to provide assistance. Was there something you needed from the bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants