Skip to content

Update repositories.txt #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Update repositories.txt #3584

merged 1 commit into from
Nov 9, 2023

Conversation

zimbora
Copy link
Contributor

@zimbora zimbora commented Nov 9, 2023

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

A problem was found with your submission https://github.com/zimbora/ESP32Logger2

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @zimbora
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@zimbora
Copy link
Contributor Author

zimbora commented Nov 9, 2023

@ArduinoBot

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Arduino Lint has suggestions for possible improvements to https://github.com/zimbora/ESP32Logger2:

Linting library in ESP32Logger2
INFO: No header file found matching library name (ESP32Logger2.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties includes field item(s) ESP32Logger.hpp not found in library.                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP052)                                                                                          
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot merged commit 8ac9a26 into arduino:main Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/zimbora/ESP32Logger2/

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@per1234 per1234 mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant