Skip to content

Feat/MKPin and Arduino-MK_HC595 lib #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2024
Merged

Feat/MKPin and Arduino-MK_HC595 lib #4697

merged 2 commits into from
Jun 23, 2024

Conversation

a3510377
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jun 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

A problem was found with your submission https://github.com/a3510377/Arduino-MK_HC595

❌ ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/a3510377/MKPin:

Linting library in MKPin
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in MKPin/examples/Analog

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Array

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/PWM

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Toggle

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @a3510377
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@a3510377
Copy link
Contributor Author

fixed @ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/a3510377/MKPin:

Linting library in MKPin
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in MKPin/examples/Analog

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Array

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/PWM

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Toggle

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/a3510377/Arduino-MK_HC595:

Linting library in Arduino-MK_HC595
INFO: No header file found matching library name (Arduino_MK_HC595_Library.h). Best practices are for primary header    
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Arduino MK_HC595 Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format        
         (Rule LP010)                                                                                                  
ERROR: Library name Arduino MK_HC595 Library starts with "Arduino". These names are reserved for official libraries.
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
       (Rule LP012)                                                                                                 
WARNING: library.properties name Arduino MK_HC595 Library contains spaces. Although supported, best practices is to not 
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Arduino MK_HC595 Library contains "library". This is superfluous.                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 4 WARNINGS

-------------------

Linting sketch in Arduino-MK_HC595/examples/GeneralDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino-MK_HC595/examples/SimplifiedUse

Linter results for project: no errors or warnings

-------------------

Linting sketch in Arduino-MK_HC595/examples/ToggleAll

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 4 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @a3510377
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/a3510377/MKHC595:

Linting library in MKHC595
INFO: No header file found matching library name (Arduino_MKHC595_Library.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Arduino MKHC595 Library is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
ERROR: Library name Arduino MKHC595 Library starts with "Arduino". These names are reserved for official libraries.
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format      
       (Rule LP012)                                                                                                
WARNING: library.properties name Arduino MKHC595 Library contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Library name Arduino MKHC595 Library contains "library". This is superfluous.                         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

Linting sketch in MKHC595/examples/GeneralDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKHC595/examples/SimplifiedUse

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKHC595/examples/ToggleAll

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/a3510377/MKPin:

Linting library in MKPin
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in MKPin/examples/Analog

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Array

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/PWM

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Toggle

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @a3510377
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

a3510377 added a commit to a3510377/MKHC595 that referenced this pull request Jun 23, 2024
@a3510377
fix for arduino/library-registry#4697 (comment)
5fe0643
@a3510377 a3510377 marked this pull request as draft June 23, 2024 01:07
@a3510377
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/a3510377/MKPin:

Linting library in MKPin
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in MKPin/examples/Analog

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Array

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/PWM

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKPin/examples/Toggle

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/a3510377/MKHC595:

Linting library in MKHC595
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in MKHC595/examples/GeneralDemo

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKHC595/examples/SimplifiedUse

Linter results for project: no errors or warnings

-------------------

Linting sketch in MKHC595/examples/ToggleAll

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @a3510377
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@a3510377
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 June 23, 2024 01:18
@a3510377 a3510377 marked this pull request as ready for review June 23, 2024 01:19
@github-actions github-actions bot removed request for per1234 June 23, 2024 01:19
@github-actions github-actions bot merged commit 4d797fb into arduino:main Jun 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/a3510377/MKPin/
http://downloads.arduino.cc/libraries/logs/github.com/a3510377/MKHC595/

github-actions bot pushed a commit that referenced this pull request Jun 23, 2024
@ArduinoBot
Add submission # 4697
95c7ec3 
#4697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
topic: submission Add library to the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a3510377