Skip to content

Remove EspNowNetwork #4975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Remove EspNowNetwork #4975

merged 2 commits into from
Aug 13, 2024

Conversation

Johboh
Copy link
Contributor

@Johboh Johboh commented Aug 12, 2024

All of which are already registered in this registry.

- EspNowNetwork used to be a "fat" library, which was built and published as individual libraries to ESP IDF component registry and Platform IO registry using github actions. This, however, is not compatible with Arduino library registry, as each github repo need to be its own library. The EspNowNetwork has now been replaced with four individual repositories instead:
- https://github.com/Johboh/EspNowNetworkHost
- https://github.com/Johboh/EspNowNetworkHostDriver
- https://github.com/Johboh/EspNowNetworkNode
- https://github.com/Johboh/EspNowNetworkShared

All of which are already registered in this registry.
@github-actions github-actions bot added the topic: removal Remove library from the list label Aug 12, 2024
Copy link
Contributor

Hi @Johboh.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot requested a review from per1234 August 12, 2024 14:23
@per1234 per1234 mentioned this pull request Aug 12, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Johboh. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Aug 12, 2024
@umbynos umbynos self-assigned this Aug 13, 2024
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #4976 (review)

Copy link
Contributor

Hi @umbynos.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot removed the status: pending backend Depends on backend maintenance operations label Aug 13, 2024
@github-actions github-actions bot requested a review from per1234 August 13, 2024 10:46
@umbynos umbynos added the status: pending backend Depends on backend maintenance operations label Aug 13, 2024
@umbynos umbynos merged commit 2c74aa6 into arduino:main Aug 13, 2024
12 checks passed
@umbynos umbynos added the conclusion: resolved Issue was resolved label Aug 13, 2024
@Johboh Johboh deleted the patch-1 branch August 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: removal Remove library from the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants