Skip to content

Update repositories.txt for AMY #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

bwhitman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Aug 26, 2024
Copy link
Contributor

A problem was found with your submission https://github.com/shorepine/amy

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @bwhitman
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@bwhitman
Copy link
Contributor Author

@ArduinoBot added the release

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/shorepine/amy:

Linting library in amy
INFO: No header file found matching library name (AMY_Synthesizer.h). Best practices are for primary header filename to 
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name AMY Synthesizer contains spaces. Although supported, best practices is to not use      
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in amy/examples/AMY_Test_ESP32

Linter results for project: no errors or warnings

-------------------

Linting sketch in amy/examples/AMY_Test_ESP32_DualCore

Linter results for project: no errors or warnings

-------------------

Linting sketch in amy/examples/AMY_Test_Pi_Pico

Linter results for project: no errors or warnings

-------------------

Linting sketch in amy/examples/AMY_Test_Pico_USB_MIDI_Synth

Linter results for project: no errors or warnings

-------------------

Linting sketch in amy/examples/AMY_Test_Teensy

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit f905971 into arduino:main Aug 26, 2024
12 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/shorepine/amy/

github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant