-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add Arduino library for HLK-LD2410S module #6537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A problem was found with your submission https://github.com/phuongnamzz/HLK-LD2410S ❌ ERROR: The repository has no tags. You need to create a release or tag that matches the |
A problem was found with your submission https://github.com/phuongnamzz/HLK-LD6002 ❌ ERROR: Submission URL is already in the Library Manager index. |
Thanks for your interest in contributing to the Arduino Library Manager index @phuongnamzz After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @phuongnamzz. Thanks for your interest in contributing to the Arduino Library Manager.
I see the bot reported a couple of problems with your submission that will block its acceptance:
Lack of Release/Tag in Library Repository
A problem was found with your submission https://github.com/phuongnamzz/HLK-LD2410S
❌ ERROR: The repository has no tags. You need to create a release or tag that matches the
version
value in the library's library.properties file.
You must create a new release or tag in the library repository. You can learn how to do that from this tutorial:
Duplicate URL
A problem was found with your submission https://github.com/phuongnamzz/HLK-LD6002
❌ ERROR: Submission URL is already in the Library Manager index.
In addition to the correct change of adding the https://github.com/phuongnamzz/HLK-LD2410S
URL to the list, your pull request also incorrectly proposes to add the URL https://github.com/phuongnamzz/HLK-LD6002
to the file, even though you already added that library in #6484.
The reason this happened is because you submitted this pull request from a branch of your fork repository that is outdated compared to the main
branch here in the arduino/library-registry
repository.
In the future, make sure to always create a dedicated branch in your fork for each pull request. You should never make any commits directly to the main
branch in your fork. The main
branch should always match the main
branch in this repository exactly. This way, you can use the main
branch as the base for the branches you create for your pull requests. You can learn how to do that from this tutorial:
Always make sure the main
branch in your fork is in sync with the main
branch in this repository before you make the branch for your pull request. You can learn how to sync your fork from the documentation here:
After you fix the problem that introduced the duplicate URL, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
@ArduinoBot please check again |
Hello! I'm checking your submission again. |
A problem was found with your submission https://github.com/phuongnamzz/HLK-LD6002 ❌ ERROR: Submission URL is already in the Library Manager index. |
Arduino Lint has suggestions for possible improvements to https://github.com/phuongnamzz/HLK-LD2410S:
|
Thanks for your interest in contributing to the Arduino Library Manager index @phuongnamzz After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
Hi @phuongnamzz. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
No description provided.