Skip to content

add Arduino library for HLK-LD2410S module #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

phuongnamzz
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

A problem was found with your submission https://github.com/phuongnamzz/HLK-LD2410S

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

github-actions bot commented Jul 4, 2025

A problem was found with your submission https://github.com/phuongnamzz/HLK-LD6002

ERROR: Submission URL is already in the Library Manager index.

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @phuongnamzz
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234 per1234 self-assigned this Jul 4, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @phuongnamzz. Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a couple of problems with your submission that will block its acceptance:

Lack of Release/Tag in Library Repository

A problem was found with your submission https://github.com/phuongnamzz/HLK-LD2410S

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

You must create a new release or tag in the library repository. You can learn how to do that from this tutorial:

https://docs.github.com/github/administering-a-repository/releasing-projects-on-github/managing-releases-in-a-repository

Duplicate URL

A problem was found with your submission https://github.com/phuongnamzz/HLK-LD6002

❌ ERROR: Submission URL is already in the Library Manager index.

In addition to the correct change of adding the https://github.com/phuongnamzz/HLK-LD2410S URL to the list, your pull request also incorrectly proposes to add the URL https://github.com/phuongnamzz/HLK-LD6002 to the file, even though you already added that library in #6484.

The reason this happened is because you submitted this pull request from a branch of your fork repository that is outdated compared to the main branch here in the arduino/library-registry repository.

In the future, make sure to always create a dedicated branch in your fork for each pull request. You should never make any commits directly to the main branch in your fork. The main branch should always match the main branch in this repository exactly. This way, you can use the main branch as the base for the branches you create for your pull requests. You can learn how to do that from this tutorial:

https://docs.github.com/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

Always make sure the main branch in your fork is in sync with the main branch in this repository before you make the branch for your pull request. You can learn how to sync your fork from the documentation here:

https://docs.github.com/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

After you fix the problem that introduced the duplicate URL, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.


If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jul 4, 2025
@phuongnamzz
Copy link
Contributor Author

@ArduinoBot please check again

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

A problem was found with your submission https://github.com/phuongnamzz/HLK-LD6002

ERROR: Submission URL is already in the Library Manager index.

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/phuongnamzz/HLK-LD2410S:

Linting library in HLK-LD2410S
INFO: No header file found matching library name (HLK-LD2410S.h). Best practices are for primary header filename to     
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Thanks for your interest in contributing to the Arduino Library Manager index @phuongnamzz
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

github-actions bot commented Jul 4, 2025

Hi @phuongnamzz.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added topic: other Something other than a library list request and removed topic: submission Add library to the list labels Jul 4, 2025
@github-actions github-actions bot requested a review from per1234 July 4, 2025 13:31
@per1234 per1234 added conclusion: duplicate Has already been submitted topic: submission Add library to the list and removed topic: other Something other than a library list request labels Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants