Skip to content

Add https://github.com/0neblock/Arduino_SNMP #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Add https://github.com/0neblock/Arduino_SNMP #675

merged 1 commit into from
Nov 14, 2021

Conversation

0neblock
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Nov 14, 2021
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/0neblock/Arduino_SNMP:

Linting library in Arduino_SNMP
INFO: No header file found matching library name (Arduino_SNMP2.h). Best practices are for primary header filename to   
      match library name. (Rule LS008)                                                                                  
ERROR: Library name Arduino_SNMP2 starts with "Arduino". These names are reserved for official libraries. (Rule LP012)
ERROR: Missing url field in library.properties. See                                                                     
       https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format (Rule LP040)   

Linter results for project: 2 ERRORS, 0 WARNINGS

-------------------

Linting sketch in Arduino_SNMP/examples/ESP32_SNMP

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 2 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @0neblock
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@0neblock
Copy link
Contributor Author

@per1234 This PR seems to be broken. The original repo has been fixed but the linter seems to be running against a cached version of the repo? https://github.com/0neblock/Arduino_SNMP

@0neblock
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/0neblock/Arduino_SNMP:

Linting library in Arduino_SNMP
INFO: No header file found matching library name (Arduino_SNMP2.h). Best practices are for primary header filename to   
      match library name. (Rule LS008)                                                                                  
ERROR: Library name Arduino_SNMP2 starts with "Arduino". These names are reserved for official libraries. (Rule LP012)
ERROR: Missing url field in library.properties. See                                                                     
       https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format (Rule LP040)   

Linter results for project: 2 ERRORS, 0 WARNINGS

-------------------

Linting sketch in Arduino_SNMP/examples/ESP32_SNMP

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 2 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @0neblock
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Nov 14, 2021

Hello @0neblock. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

@arduino arduino deleted a comment from github-actions bot Nov 14, 2021
@arduino arduino deleted a comment from github-actions bot Nov 14, 2021
@arduino arduino deleted a comment from github-actions bot Nov 14, 2021
@0neblock
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit 94c60a3 into arduino:main Nov 14, 2021
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/0neblock/Arduino_SNMP/

github-actions bot pushed a commit that referenced this pull request Nov 14, 2021
@0neblock 0neblock deleted the patch-1 branch November 14, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants