-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
a #6944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a #6944
Conversation
A problem was found with your submission https://github.com/Droidbane/ESPWiFiManagerByDroidbane ❌ ERROR: Library is missing a library.properties metadata file. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata |
Thanks for your interest in contributing to the Arduino Library Manager index @Droidbane After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
Please help. I added the required properties file everywhere and even created a .json file, but I still continue to get the same error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Droidbane. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/Droidbane/ESPWiFiManagerByDroidbane/tree/1.0.0
(note that the library.properties
file was not present in the root of the repository at that tagged point in the revision history)
❗ Remember to update the value of the version
property in the library's library.properties
file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
In the future please only create one pull request for each submission.
As was already clearly explained in the comments from the bot, there is no need or point in submitting a new pull request after a problem is detected with your existing PR.
What you must do instead is CAREFULLY read the information provided by the bot and then fix the problem. Once you do that, another round of automated checks will be triggered. You can repeat that process in a single pull request as many times as is needed to get it to a fully compliant state. Once your submission passes all the checks it will automatically be accepted by the bot.
You will never fix the problem by submitting the same non-compliant pull request multiple times. That will only waste your time and the time of the humans who maintain this free open source project.
⚠ Repeated irresponsible behavior may result in the revocation of your Library Manager Registry privileges.
Thanks in advance for your cooperation.
Hello! I'm checking your submission again. |
Arduino Lint has suggestions for possible improvements to https://github.com/Droidbane/ESPWiFiManagerByDroidbane:
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
No description provided.