Skip to content

Update repositories.txt #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2021
Merged

Update repositories.txt #714

merged 1 commit into from
Nov 22, 2021

Conversation

fangamy
Copy link
Contributor

@fangamy fangamy commented Nov 22, 2021

tuya ble mcu sdk

@fangamy
Update repositories.txt
616b37b 
tuya ble mcu sdk
@github-actions github-actions bot added the topic: submission Add library to the list label Nov 22, 2021
@github-actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/tuya/tuya-ble-mcu-sdk-arduino-library:

Linting library in tuya-ble-mcu-sdk-arduino-library
INFO: No header file found matching library name (Tuya_BLE_MCU_SDK.h). Best practices are for primary header filename to
      match library name. (Rule LS008)                                                                                  
ERROR: library.properties url value is less than minimum length. (Rule LP056)
WARNING: library.properties url field value  does not have a valid URL format. (Rule LP041)
WARNING: Unable to load the library.properties url field: Head "": unsupported protocol scheme "" (Rule LP042)

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_dp_process

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_led

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_shock

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_temp_hum_press

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @fangamy
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@fangamy
Copy link
Contributor Author

fangamy commented Nov 22, 2021

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/tuya/tuya-ble-mcu-sdk-arduino-library:

Linting library in tuya-ble-mcu-sdk-arduino-library
INFO: No header file found matching library name (Tuya_BLE_MCU_SDK.h). Best practices are for primary header filename to
      match library name. (Rule LS008)                                                                                  
ERROR: library.properties url value is less than minimum length. (Rule LP056)
WARNING: library.properties url field value  does not have a valid URL format. (Rule LP041)
WARNING: Unable to load the library.properties url field: Head "": unsupported protocol scheme "" (Rule LP042)

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_dp_process

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_led

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_shock

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_temp_hum_press

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @fangamy
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@fangamy
Copy link
Contributor Author

fangamy commented Nov 22, 2021

update library.properties,，@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@per1234
Copy link
Contributor

per1234 commented Nov 22, 2021

@fangamy
@fangamy
@fangamy
@fangamy
@fangamy

Hi. Let's talk about this. If you keep doing the same thing, you are going to keep getting the same result. I'm here to help you, but I can only do that if you communicate with me. Please just leave this PR open so we can have a conversation and get this resolved.

I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags. You can see that at the last tag the problem was still present:
https://github.com/tuya/tuya-ble-mcu-sdk-arduino-library/blob/0.0.1/library.properties#L8

So the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

@github-actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/tuya/tuya-ble-mcu-sdk-arduino-library:

Linting library in tuya-ble-mcu-sdk-arduino-library
INFO: No header file found matching library name (Tuya_BLE_MCU_SDK.h). Best practices are for primary header filename to
      match library name. (Rule LS008)                                                                                  
ERROR: library.properties url value is less than minimum length. (Rule LP056)
WARNING: library.properties url field value  does not have a valid URL format. (Rule LP041)
WARNING: Unable to load the library.properties url field: Head "": unsupported protocol scheme "" (Rule LP042)

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_dp_process

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_led

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_shock

Linter results for project: no errors or warnings

-------------------

Linting sketch in tuya-ble-mcu-sdk-arduino-library/examples/ble_temp_hum_press

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @fangamy
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@fangamy
Copy link
Contributor Author

fangamy commented Nov 22, 2021

I‘m sorry，@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit d27f044 into arduino:main Nov 22, 2021
github-actions bot pushed a commit that referenced this pull request Nov 22, 2021
@ArduinoBot
Add submission # 714
09d5aa2 
#714
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/tuya/tuya-ble-mcu-sdk-arduino-library/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
topic: submission Add library to the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangamy @per1234