Skip to content

Update repositories.txt #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Update repositories.txt #784

merged 1 commit into from
Dec 14, 2021

Conversation

armp30
Copy link
Contributor

@armp30 armp30 commented Dec 14, 2021

No description provided.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/viralinkio/ViraLink-MQTT-Client

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 14, 2021
@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @armp30
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@@ -4456,3 +4456,4 @@ https://github.com/dndubins/QuickStats
https://github.com/vChavezB/uc-os3-arduino-due.git
https://github.com/fabriziop/FIFOEE.git
https://github.com/sparkfun/SparkFun_Qwiic_Fan_Arduino_Library
https://github.com/viralinkio/ViraLink-MQTT-Client
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@armp30
Copy link
Contributor Author

armp30 commented Dec 14, 2021

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/viralinkio/ViraLink-MQTT-Client

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @armp30
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@armp30
Copy link
Contributor Author

armp30 commented Dec 14, 2021

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/viralinkio/ViraLink-MQTT-Client

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @armp30
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@per1234
Copy link
Contributor

per1234 commented Dec 14, 2021

Hello @armp30. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

You can see here that the tagged version of the library being checked by the bot is still missing the library.properties file:

https://github.com/viralinkio/ViraLink-MQTT-Client/tree/0.50

Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

@armp30
Copy link
Contributor Author

armp30 commented Dec 14, 2021

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/viralinkio/ViraLink-MQTT-Client:

Linting library in ViraLink-MQTT-Client
INFO: No header file found matching library name (ViraLink-MQTT-CLient.h). Best practices are for primary header        
      filename to match library name. (Rule LS008)                                                                      
WARNING: library.properties name value ViraLink-MQTT-CLient is longer than the recommended length of 16 characters.     
         (Rule LP010)                                                                                                   
WARNING: No license file found. See:                                                                                                                  
         https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/licensing-a-repository#detecting-a-license
         (Rule LD002)                                                                                                                                 
WARNING: No example sketches found. Please provide examples. See:                                                       
         https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples (Rule LD004)              

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

@github-actions github-actions bot merged commit b5a6339 into arduino:main Dec 14, 2021
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/viralinkio/ViraLink-MQTT-Client/

github-actions bot pushed a commit that referenced this pull request Dec 14, 2021
@armp30 armp30 deleted the patch-1 branch December 14, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants