Skip to content

Adding LCD library #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Conversation

turing-complete-labs
Copy link
Contributor

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 30, 2022
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/turing-complete-labs/LCDDisplay10_Arduino

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @turing-complete-labs
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@turing-complete-labs
Copy link
Contributor Author

I added the file, commented on the original pull request as explained.
Closed the previous one, created a new PR, still the bot complains about the file non-existing:
https://github.com/turing-complete-labs/LCDDisplay10_Arduino/blob/main/library.properties
¯_(ツ)_/¯

@per1234 per1234 self-assigned this Jan 30, 2022
@per1234
Copy link
Contributor

per1234 commented Jan 30, 2022

Hello @turing-complete-labs. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

You can see here that at the current tagged version of the library the file was missing:

https://github.com/turing-complete-labs/LCDDisplay10_Arduino/tree/1.0

Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

@turing-complete-labs
Copy link
Contributor Author

@ArduinoBot fixed.
@per1234 Thank you!

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/turing-complete-labs/LCDDisplay10_Arduino:

Linting library in LCDDisplay10_Arduino
WARNING: Missing architectures field in library.properties. See                                                         
         https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format (Rule LP043) 

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LCDDisplay10_Arduino/examples/basic
WARNING: basic.pde uses deprecated .pde file extension. Use .ino for Arduino sketches. (Rule SS004)

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit bcdd3c0 into arduino:main Jan 30, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/turing-complete-labs/LCDDisplay10_Arduino/

github-actions bot pushed a commit that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants