Ae 591 configure correctly the sw1 and sw3 pmic output rails #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd they were outputting wrong voltages, now this has been fixed.
|
|
|
@bogdanarduino Could you please add in the code a paragraph explaining why this sequence of commands is necessary? |
|
also drop 5061933 we will re add it at the time we will make a new release |
bogdanarduino
force-pushed
the
AE-591_configure_correctly_the_SW1_and_SW3_PMIC_output_rails
branch
from
5061933 to
4b22633
Compare
…roduced PMIC configuration.
sebromero
requested changes
Aug 28, 2025
app/power/power.cpp
Outdated
| data[1]=0x7; | ||
| i2c.write(8 << 1, data, sizeof(data)); | ||
|
|
||
| // SW1 to 3.0V (SW1_VOLT) |
There was a problem hiding this comment.
Suggested change
| // SW1 to 3.0V (SW1_VOLT) | |
| // SW1 turn on (turned off by OTP settings) (SW1_CTRL) |
There was a problem hiding this comment.
Pushed suggested change, without the OTP mention, since the rail was turned off by prior commands and not via the OTP config.
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
…rails' of https://github.com/arduino/mcuboot-arduino-stm32h7 into AE-591_configure_correctly_the_SW1_and_SW3_PMIC_output_rails
sebromero
requested changes
Sep 2, 2025
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
sebromero
deleted the
AE-591_configure_correctly_the_SW1_and_SW3_PMIC_output_rails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed I2C command sequence in "power.cpp" to correctly configure SW1 (3V1) and SW2 (3V3) PMIC output voltages during bootloader start-up. Detailed context of the original issue and need for the fixed can be found under https://arduino.atlassian.net/browse/AE-591.