Fix quit message not being printed
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
topic: code
umbynos
approved these changes
Nov 25, 2021
cmaglie
reviewed
Nov 25, 2021
| @@ -292,5 +306,8 @@ func (d *Server) outputProcessor(outWriter io.Writer) { | |||
| } | |||
| fmt.Fprintln(outWriter, string(data)) | |||
| } | |||
| // We finished consuming all messages, now | |||
| // we can exit for real | |||
| d.outputWaiter.Done() | |||
There was a problem hiding this comment.
What about dropping the channel + goroutine + waitgroup + d.quit in change of a mutex?
outputMutext.Lock()
output.Write(data)
outputMutex.Unlock()
There was a problem hiding this comment.
That would be mean refactor everything again, I'd prefer to avoid that. 😖
On every push and pull request that affects relevant files, run the project's Go code tests.
silvanocerza
force-pushed
the
scerza/fix-quit-message
branch
from
89b039a to
84341ca
Compare
silvanocerza
force-pushed
the
scerza/fix-quit-message
branch
from
84341ca to
91f7240
Compare
cmaglie
approved these changes
Nov 26, 2021
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the
quitsuccessful message wasn't sent since the goroutine consuming messages to output wouldn't be fast enough.Before:
After: