Report all failures of Go nightly template workflow #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
silvanocerza
approved these changes
Jun 21, 2021
Previously, the configuration of the workflow was such that a Datadog report was only submitted when the `publish-nightly` job failed. In the event one of the other jobs failed, the `publish-nightly` job never ran, and neither did the failure handling step inside the job. We already had a real life event where the Arduino CLI nightly was failing due to a notarization problem, which was not reported due to the workflow configuration.
per1234
force-pushed
the
report-nightly-fail
branch
from
46aebeb to
3c1c351
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the configuration of the workflow was such that a Datadog report was only submitted when the
publish-nightlyjob failed. In the event one of the other jobs failed, thepublish-nightlyjob never ran, and neitherdid the failure handling step inside the job.
We already had a real life event where the Arduino CLI nightly was failing due to a notarization problem, which was not
reported due to the workflow configuration.