Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAVError is an undefined name in generator/mavparse.py #116

Closed
cclauss opened this issue Aug 31, 2017 · 2 comments
Closed

MAVError is an undefined name in generator/mavparse.py #116

cclauss opened this issue Aug 31, 2017 · 2 comments

Comments

@cclauss
Copy link
Contributor

cclauss commented Aug 31, 2017

MAVError is defined in generator/mavgen_python.py and is used in generator/mavparse.py but is never imported.

cclauss pushed a commit to cclauss/pymavlink that referenced this issue Aug 31, 2017
Undefined names can cause `NameError` exceptions to be raised at runtime.  It is also helpful for spotting Python 3 incompatibilities (raw_input(), unicode(), xrange(), etc.).  Adding this test to our critical error search will increase runtime stability.  ArduPilot#114, ArduPilot#115, and ArduPilot#116 should be fixed __before__ this PR is merged.
@amilcarlucas
Copy link
Contributor

No file changes here. why ?

@cclauss
Copy link
Contributor Author

cclauss commented Sep 3, 2017

@amilcarlucas My attempt to fix resulted in circular imports so I opened an issue in hopes that fresh eyes could find a solution.

cclauss pushed a commit to cclauss/pymavlink that referenced this issue Sep 7, 2017
Fixes ArduPilot#116,ArduPilot#117

In pymavlink/generator/mavparse.py from .mavgen_python import MAVError to resolve undefined name which can raise `NameError` at runtime.
peterbarker pushed a commit that referenced this issue Jan 10, 2018
Undefined names can cause `NameError` exceptions to be raised at runtime.  It is also helpful for spotting Python 3 incompatibilities (raw_input(), unicode(), xrange(), etc.).  Adding this test to our critical error search will increase runtime stability.  #114, #115, and #116 should be fixed __before__ this PR is merged.
amilcarlucas pushed a commit to amilcarlucas/pymavlink that referenced this issue Jan 10, 2018
Undefined names can cause `NameError` exceptions to be raised at runtime.  It is also helpful for spotting Python 3 incompatibilities (raw_input(), unicode(), xrange(), etc.).  Adding this test to our critical error search will increase runtime stability.  ArduPilot#114, ArduPilot#115, and ArduPilot#116 should be fixed __before__ this PR is merged.
amilcarlucas pushed a commit to amilcarlucas/pymavlink that referenced this issue Jan 10, 2018
In pymavlink/generator/mavparse.py from .mavgen_python import MAVError to resolve undefined name which can raise `NameError` at runtime.

Resolve the circular imports between mavgen_python.py, mavparse.py, and mavtemplate.py by putting MAVError and MAVParseError into their own maverrors.py file.

Fixes ArduPilot#116,ArduPilot#117
kd0aij pushed a commit to kd0aij/pymavlink that referenced this issue Jun 19, 2018
Undefined names can cause `NameError` exceptions to be raised at runtime.  It is also helpful for spotting Python 3 incompatibilities (raw_input(), unicode(), xrange(), etc.).  Adding this test to our critical error search will increase runtime stability.  ArduPilot#114, ArduPilot#115, and ArduPilot#116 should be fixed __before__ this PR is merged.
kd0aij pushed a commit to kd0aij/pymavlink that referenced this issue Jun 19, 2018
In pymavlink/generator/mavparse.py from .mavgen_python import MAVError to resolve undefined name which can raise `NameError` at runtime.

Resolve the circular imports between mavgen_python.py, mavparse.py, and mavtemplate.py by putting MAVError and MAVParseError into their own maverrors.py file.

Fixes ArduPilot#116,ArduPilot#117
beforezod pushed a commit to beforezod/pymavlink that referenced this issue Feb 26, 2019
In pymavlink/generator/mavparse.py from .mavgen_python import MAVError to resolve undefined name which can raise `NameError` at runtime.

Resolve the circular imports between mavgen_python.py, mavparse.py, and mavtemplate.py by putting MAVError and MAVParseError into their own maverrors.py file.

Fixes ArduPilot#116,ArduPilot#117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants