-
Notifications
You must be signed in to change notification settings - Fork 191
Adds rightAlignYAxis chart, spec and feature inheritance improvements. #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds rightAlignYAxis chart, spec and feature inheritance improvements. #155
Conversation
rendering options like show_controls and no_data_message
Thanks for the PR! |
The other chart types also support these features (show controls toggle and no data message is universal) so I believe they should also have the template change. Otherwise they do not render these options when they are set. I can do some extra testing around this though if needed. |
Yes please, for sake of consistency it makes sense we update all the chart when we add an option |
Looks like this will be included in cumulativelinechart.html, because that template calls
For templates that don't call |
{% endif %} | ||
|
||
{% block rendering_opts %} | ||
{% if chart.no_data_message %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is written out instead of just calling super
because pie chart cannot have the stacked
option but it can have the no_data_message
and show_controls
options. If we're okay with including stacked
(and just count on people not trying to apply it to pie chart) I can revise this to just call super()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good with me!
Thanks for following up! |
Features in this PR:
multiChart
show_controls
toggle andno_data_message