Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint bug #272

Merged
merged 7 commits into from
Jul 15, 2019
Merged

Constraint bug #272

merged 7 commits into from
Jul 15, 2019

Conversation

gwenchee
Copy link
Collaborator

This PR addresses #271

@pep8speaks
Copy link
Contributor

pep8speaks commented Jul 13, 2019 •
edited
Loading

Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-15 13:46:16 UTC

@gwenchee gwenchee requested a review from robfairh July 13, 2019 22:22
@gwenchee gwenchee requested review from katyhuff and removed request for katyhuff July 13, 2019 22:26
robfairh
robfairh requested changes Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@robfairh robfairh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that extra variable, looks good!

@gwenchee @robfairh
Update d3ploy/supply_driven_deployment_inst.py
fe662e5 
Co-Authored-By: robfairh <43791150+robfairh@users.noreply.github.com>
@gwenchee
Copy link
Collaborator Author

I removed the extra variable @robfairh

@robfairh robfairh self-requested a review July 15, 2019 16:41
robfairh
robfairh approved these changes Jul 15, 2019
View reviewed changes
Copy link
Collaborator

@robfairh robfairh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robfairh robfairh merged commit 157ae56 into arfc:master Jul 15, 2019
@gwenchee gwenchee deleted the constraintbug branch July 15, 2019 17:42
@gwenchee gwenchee mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robfairh robfairh robfairh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwenchee @pep8speaks @robfairh