extractSerpent2GCs.py fix #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, OK, this makes sense. Interesting that this error was in there for quite a while! I will request a single change: could you change it so that rather than saying if (not secBranch) else , it instead says if (secBranch) else ? It is more easy to read then. Aside from that, the fix looks good. |
|
Sure I'll swap them around |
|
Well, yep, once the PEP8 stuff is addressed I'll merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest change by @gridley introduced automatic checking for the number of DNP groups (6 or 8 depending on the nuclear data library) to remove extra zeros if there are only 6 groups.
The script works for cases with secondary branches (resulting from Serpent automated burnup sequences or varying control rod positions)
The script fails for cases without secondary branches as the "branch" variable is null. The fix simply involves removing the "branch" variable call for these cases in the DNP group check.
The if-else code portions are also swapped to maintain consistency with the original code.