Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing OpenMC group constant generation in moltres_xs.py #174

Merged
merged 60 commits into from
Nov 1, 2021

Conversation

gwenchee
Copy link
Contributor

@gwenchee gwenchee commented Oct 12, 2021

This PR addresses #126, adds a test for the OpenMC group constant extraction capability, and adds a tutorial on how to use it.

@pep8speaks
Copy link

pep8speaks commented Oct 12, 2021

Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-29 22:01:40 UTC

@gwenchee
Copy link
Contributor Author

I just amended moltres_xs.py and the README to reflect the addition of generating group constants for openmc.Cell domains (previously it was only enabled for openmc.Material domains). I have no further changes

@yardasol yardasol self-requested a review October 20, 2021 18:56
Copy link
Collaborator

@smpark7 smpark7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this complicated yet important task! Overall, this looks great! I have some review comments here and there for minor issues.

python/moltres_xs.py Show resolved Hide resolved
python/moltres_xs.py Show resolved Hide resolved
python/moltres_xs.py Show resolved Hide resolved
tutorial/godiva/README.md Show resolved Hide resolved
python/moltres_xs.py Outdated Show resolved Hide resolved
tutorial/godiva/godiva_openmc_900.py Outdated Show resolved Hide resolved
tutorial/godiva/godiva_openmc_1200.py Outdated Show resolved Hide resolved
@gwenchee
Copy link
Contributor Author

@munkm The test shows it needs the developer to activate it. This seems to be the same issue from #169

@smpark7
Copy link
Collaborator

smpark7 commented Oct 25, 2021

@munkm The test shows it needs the developer to activate it. This seems to be the same issue from #169

I just activated the tests for you. I somehow have access to activating tests again

@gwenchee
Copy link
Contributor Author

Does it work for you now? @smpark7

@gwenchee gwenchee requested a review from smpark7 October 29, 2021 22:19
@smpark7
Copy link
Collaborator

smpark7 commented Oct 29, 2021

@pep8speaks

@smpark7 smpark7 merged commit 51bcbe2 into arfc:devel Nov 1, 2021
github-actions bot pushed a commit that referenced this pull request Nov 1, 2021
Implementing OpenMC group constant generation in moltres_xs.py 51bcbe2
github-actions bot pushed a commit to gwenchee/moltres that referenced this pull request Nov 3, 2021
Implementing OpenMC group constant generation in moltres_xs.py 51bcbe2
github-actions bot pushed a commit to smpark7/moltres that referenced this pull request Nov 8, 2021
Implementing OpenMC group constant generation in moltres_xs.py 51bcbe2
@gwenchee gwenchee deleted the openmc-xs-impl branch February 22, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants