fix: add inhertied to pod_target_xcconfig #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @michaellee8 |
|
@DarthMike it looks like you guys didn't publish to fixed pubspec to cocopods. Can you kindly double check that? https://github.com/CocoaPods/Specs/blob/master/Specs/a/9/6/web3.swift/0.8.1/web3.swift.podspec.json |
|
@michaellee8 just published 0.8.2 with the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is found that in React Native builds, which does not seems to
use_framework!, the swift compiler is unable to find theBigIntandGenericJSONdependencies for theweb3.swiftduring the build process, causing build failure. After reviewing the project configuration, I have found thepod_target_xcconfigin podspec to be supcisious, and the problem was fixed after adding$(inherited)to the config.