Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Labeling Rules] Filter uncovered records #951

Closed
frascuchon opened this issue Jan 13, 2022 · 3 comments · Fixed by #1156
Closed

[Labeling Rules] Filter uncovered records #951

frascuchon opened this issue Jan 13, 2022 · 3 comments · Fixed by #1156
Assignees
@dvsrepo @frascuchon @dcfidalgo @leiyre @Amelie-V
Labels
area: server Indicates that an issue or pull request is related to the server
Projects
Release

Comments

@frascuchon
Copy link
Member

It could be nice to explore/annotate records that are not covered by any defined rule. Some kind of filter that we can leave activated while navigating between modes
@frascuchon frascuchon added app area: server Indicates that an issue or pull request is related to the server labels Jan 13, 2022
@frascuchon frascuchon added this to To do in Release via automation Jan 13, 2022
@frascuchon frascuchon moved this from To do to TODO Release in Release Jan 17, 2022
@frascuchon frascuchon mentioned this issue Jan 17, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release Jan 17, 2022
@frascuchon frascuchon moved this from In progress to Planified in Release Jan 18, 2022
@frascuchon frascuchon moved this from Planified to In progress in Release Jan 18, 2022
frascuchon added a commit that referenced this issue Jan 19, 2022
@frascuchon
feat(#951): new uncovered_by_rules records filter (#991)
164440b 
* feat(api): new only_uncovered records filter

* feat: add uncovered_by_rules filter param

* feat(text-class): update query request model

* refactor: configure must_not filters

* test: add missing tests

* revert: list rules prior to generate query

* Apply suggestions from code review

Co-authored-by: David Fidalgo <david@recogn.ai>

* test: add functional test

Co-authored-by: David Fidalgo <david@recogn.ai>
dvsrepo added a commit that referenced this issue Jan 25, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8f89dda 
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
@leiyre leiyre closed this as completed Jan 27, 2022
Release automation moved this from In progress to Done Jan 27, 2022
@leiyre leiyre reopened this Jan 27, 2022
Release automation moved this from Done to In progress Jan 27, 2022
@frascuchon frascuchon moved this from In progress to Planified in Release Jan 31, 2022
@frascuchon frascuchon moved this from Planified to Backlog in Release Jan 31, 2022
frascuchon added a commit that referenced this issue Feb 7, 2022
@frascuchon
feat(#951): new uncovered_by_rules records filter (#991)
162afa0 
* feat(api): new only_uncovered records filter

* feat: add uncovered_by_rules filter param

* feat(text-class): update query request model

* refactor: configure must_not filters

* test: add missing tests

* revert: list rules prior to generate query

* Apply suggestions from code review

Co-authored-by: David Fidalgo <david@recogn.ai>

* test: add functional test

Co-authored-by: David Fidalgo <david@recogn.ai>
(cherry picked from commit 164440b)
@Amelie-V
Copy link
Member

#991

@Amelie-V Amelie-V reopened this Feb 14, 2022
Release automation moved this from Backlog to In progress Feb 14, 2022
@Amelie-V
Copy link
Member

Amelie-V commented Feb 14, 2022 •
edited by leiyre

  • add checkbox into annotation Filter

@frascuchon frascuchon moved this from In progress to Planified in Release Feb 15, 2022
leiyre added a commit that referenced this issue Feb 15, 2022
@leiyre
feat(#951): Filter uncovered records
e55a993 
closes #951
This PR allows filtering of records by uncovered by rules
@leiyre leiyre mentioned this issue Feb 15, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release Feb 15, 2022
@frascuchon frascuchon moved this from In progress to Review in Release Feb 17, 2022
@frascuchon frascuchon moved this from Review to In progress in Release Feb 17, 2022
@frascuchon
Copy link
Member Author

More specific copy text for checkbox: "Show only not covered records by rules"

@dcfidalgo @dvsrepo @Amelie-V @leiyre ? Wha do you think?

frascuchon added a commit that referenced this issue Feb 17, 2022
@leiyre @frascuchon
feat(#951): Filter uncovered records (#1156)
6510f4c 
This PR allows filtering of records by uncovered by rules

* perf: initialize text classification with load rules definition

* chore: remove fetch rules from common filters

* persist uncovered_by_rules filter

* condition and selected filter state

* allow remove from "remove all filters"

* test FilterUncoveredByRules

* uncovered filter display condition

* checkbox label copy

* update snapshot

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
@frascuchon frascuchon moved this from In progress to Review in Release Feb 17, 2022
@frascuchon frascuchon moved this from Review to Ready to DEV QA in Release Feb 17, 2022
@frascuchon frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Feb 17, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Feb 17, 2022
frascuchon added a commit that referenced this issue Feb 17, 2022
@frascuchon
feat(#951): new not "covered records by rules" records filter (#991)
0649f2a 
feat(#951): Filter uncovered records (#1156)

This PR allows filtering of records by uncovered by rules

* perf: initialize text classification with load rules definition

* chore: remove fetch rules from common filters

* persist uncovered_by_rules filter

* condition and selected filter state

* allow remove from "remove all filters"

* test FilterUncoveredByRules

* uncovered filter display condition

* checkbox label copy

* update snapshot

Co-authored-by: Francisco Aranda <francisco@recogn.ai>
(cherry picked from commit 6510f4c)
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvsrepo dvsrepo

@frascuchon frascuchon

@dcfidalgo dcfidalgo

@leiyre leiyre

@Amelie-V Amelie-V

Labels
area: server Indicates that an issue or pull request is related to the server
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#951): Filter uncovered records argilla-io/argilla
5 participants
@dvsrepo @frascuchon @dcfidalgo @leiyre @Amelie-V