Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Errors] Errors occurred in dataset view should keep at least header layout #844

Closed
frascuchon opened this issue Dec 22, 2021 · 0 comments · Fixed by #992
Closed

[Errors] Errors occurred in dataset view should keep at least header layout #844

frascuchon opened this issue Dec 22, 2021 · 0 comments · Fixed by #992
Assignees
@leiyre @Amelie-V
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@frascuchon
Copy link
Member

The back button is the only action you can do if something was wrong. But, since we have workspaces, we could give the choice of changing workspace from here.

Screenshot 2021-12-22 at 13 55 33

As additional comment, this is possible if error happens in datasets view.

Screenshot 2021-12-22 at 13 58 35
@frascuchon frascuchon added the app label Dec 22, 2021
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Jan 13, 2022
@frascuchon frascuchon added this to To do in Release via automation Jan 13, 2022
@frascuchon frascuchon moved this from To do to TODO Release in Release Jan 17, 2022
@frascuchon frascuchon changed the title [Errors] Errors occurred in dataset view should keep at least sidebar layout [Errors] Errors occurred in dataset view should keep at least header layout Jan 17, 2022
@leiyre leiyre moved this from Planified to In progress in Release Jan 18, 2022
leiyre added a commit that referenced this issue Jan 18, 2022
@leiyre
fix(#844) Keep header layout when errors occurred in dataset view
71fd07a 
see #844
This PR includes the restructuring of dataset view and new app-header component for better control of header behaviour
@leiyre leiyre mentioned this issue Jan 18, 2022
Merged
Release automation moved this from In progress to Done Jan 18, 2022
frascuchon pushed a commit that referenced this issue Jan 18, 2022
@leiyre
fix(#844) Keep header layout when errors occurred in dataset view (#992)
5be19d4 
see #844
This PR includes the restructuring of dataset view and new app-header component for better control of header behaviour
@frascuchon frascuchon moved this from Done to Release Ready in Release Jan 18, 2022
frascuchon pushed a commit that referenced this issue Jan 19, 2022
@leiyre @frascuchon
fix(#844) Keep header layout when errors occurred in dataset view (#992)
5c32b24 
see #844
This PR includes the restructuring of dataset view and new app-header component for better control of header behaviour

(cherry picked from commit 5be19d4)
leiyre added a commit that referenced this issue Jan 20, 2022
@leiyre
fix(Breadcrumbs): Copy text function
0cef5a0 
see #844
@leiyre leiyre mentioned this issue Jan 20, 2022
Merged
frascuchon pushed a commit that referenced this issue Jan 20, 2022
@leiyre
fix(Breadcrumbs): Copy text function (#1003)
15b3eb4 
see #844
frascuchon pushed a commit that referenced this issue Jan 20, 2022
@leiyre @frascuchon
fix(Breadcrumbs): copy workspace from the breadcrumbs when dataset lo…
33e372d 
…ading has errors #1003

see #844

(cherry picked from commit 15b3eb4)
@frascuchon frascuchon moved this from Release Ready to Closed in Release Jan 20, 2022
@frascuchon frascuchon added 0.8.1 and removed 0.8.1 labels Jan 20, 2022
dvsrepo added a commit that referenced this issue Jan 25, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8f89dda 
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#844) Keep header layout when errors occurred in dataset view argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V