Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WeakLabels] bug when not providing rules #1010

Closed
dcfidalgo opened this issue Jan 20, 2022 · 0 comments · Fixed by #1011
Closed

[WeakLabels] bug when not providing rules #1010

dcfidalgo opened this issue Jan 20, 2022 · 0 comments · Fixed by #1011
Assignees
@dcfidalgo
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@dcfidalgo
Copy link
Contributor

WeakLabels has a bug when not providing rules in the init

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_191348/2782682241.py in <module>
----> 1 wl = WeakLabels(dataset="facsarss_category_v2")

~/recognai/rubrix/src/rubrix/labeling/text_classification/weak_labels.py in __init__(self, dataset, rules, ids, query, label2int)
    106                 or f"rule_{index}"
    107             )
--> 108             for index, rule in enumerate(rules)
    109         }
    110         # raise error if there are duplicates

TypeError: 'NoneType' object is not iterable
@dcfidalgo dcfidalgo self-assigned this Jan 20, 2022
@dcfidalgo dcfidalgo added labeling type: bug Indicates an unexpected problem or unintended behavior labels Jan 20, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Jan 20, 2022
@dcfidalgo dcfidalgo mentioned this issue Jan 20, 2022
Merged
Release automation moved this from Backlog to Done Jan 21, 2022
dcfidalgo pushed a commit that referenced this issue Jan 21, 2022
fix(#1010): fix WeakLabels when not providing rules (#1011)
176e48a 
* fix: bugfix when no rules but a ds is provided

* test: add test

* test: fix test
dvsrepo added a commit that referenced this issue Jan 25, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
8f89dda 
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
@frascuchon frascuchon moved this from Done to Dev deployment in Release Feb 2, 2022
@frascuchon frascuchon moved this from Dev deployment to Release Ready in Release Feb 2, 2022
frascuchon pushed a commit that referenced this issue Feb 2, 2022
@frascuchon
feat(#955): add default for rules in WeakLabels (#976)
34389d3 
* feat: load rules of dataset by default

* test: add tests

* test: fix tests

fix(#1010): fix WeakLabels when not providing rules (#1011)

* fix: bugfix when no rules but a ds is provided

* test: add test

* test: fix test
@dcfidalgo dcfidalgo moved this from Release Ready to Closed in Release Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcfidalgo dcfidalgo

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1010): fix WeakLabels when not providing rules argilla-io/argilla
2 participants
@frascuchon @dcfidalgo