-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#951): new uncovered_by_rules records filter #991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a question, did you consider making rules
an attribute of the TextClassificationQuery
? Seems more natural to me, but maybe there are obstacles I don't see.
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 110 110
Lines 4247 4250 +3
=======================================
+ Hits 4056 4059 +3
Misses 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Just a few inline suggestions
Co-authored-by: David Fidalgo <david@recogn.ai>
* 'master' of https://github.com/recognai/rubrix: (28 commits) chore(#994): simplify server start (#1014) refactor(#945): elasticsearch index configuration per task (#1018) docs(#980): Add majorityvote example to weak supervision guide (#1004) fix(#1015): manage emojis in Token Classification records (#1016) fix(#1010): fix WeakLabels when not providing rules (#1011) fix(Breadcrumbs): Copy text function (#1003) fix(statics): handle 404 errors for static files (#1006) refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005) docs: update video for spacy ner tutorial (#1000) fix(#977) Remove redirection when accessing login (#996) feat(#951): new uncovered_by_rules records filter (#991) feat(#735): add warning when agent but no prediction/annotation is provided (#987) fix(#800): limit number of metadata fields (#993) docs: improve annotate records section in web app reference (#985) fix(#844) Keep header layout when errors occurred in dataset view (#992) fix(#974): display the dropdown in the last record of the scroll (#986) refactor: compute common aggregations one by one (#990) feat(#953): add additional metrics to `LabelModel.score` method (#979) refactor(rules): using labeling rules management with vuex store (#878) feat(#955): add default for `rules` in WeakLabels (#976) ...
* feat(api): new only_uncovered records filter * feat: add uncovered_by_rules filter param * feat(text-class): update query request model * refactor: configure must_not filters * test: add missing tests * revert: list rules prior to generate query * Apply suggestions from code review Co-authored-by: David Fidalgo <david@recogn.ai> * test: add functional test Co-authored-by: David Fidalgo <david@recogn.ai> (cherry picked from commit 164440b)
feat(#951): Filter uncovered records (#1156) This PR allows filtering of records by uncovered by rules * perf: initialize text classification with load rules definition * chore: remove fetch rules from common filters * persist uncovered_by_rules filter * condition and selected filter state * allow remove from "remove all filters" * test FilterUncoveredByRules * uncovered filter display condition * checkbox label copy * update snapshot Co-authored-by: Francisco Aranda <francisco@recogn.ai> (cherry picked from commit 6510f4c)
This PR includes at API level a filter param for text classification to enable only uncovered records in search results (in addition with other search parameters)
See #951