refactor(rules): using labeling rules management with vuex store #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
changed the title
frascuchon
force-pushed
the
refactor/using-store-for-rules-management
branch
from
a35569b
to
41ef6c5
Compare
frascuchon
force-pushed
the
refactor/using-store-for-rules-management
branch
from
41ef6c5
to
360823a
Compare
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
=======================================
Coverage 95.50% 95.51%
=======================================
Files 109 109
Lines 4208 4212 +4
=======================================
+ Hits 4019 4023 +4
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
leiyre
approved these changes
Jan 13, 2022
frascuchon
commented
Jan 16, 2022
leiyre
approved these changes
Jan 17, 2022
dvsrepo
added a commit
that referenced
this pull request
Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix: (28 commits) chore(#994): simplify server start (#1014) refactor(#945): elasticsearch index configuration per task (#1018) docs(#980): Add majorityvote example to weak supervision guide (#1004) fix(#1015): manage emojis in Token Classification records (#1016) fix(#1010): fix WeakLabels when not providing rules (#1011) fix(Breadcrumbs): Copy text function (#1003) fix(statics): handle 404 errors for static files (#1006) refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005) docs: update video for spacy ner tutorial (#1000) fix(#977) Remove redirection when accessing login (#996) feat(#951): new uncovered_by_rules records filter (#991) feat(#735): add warning when agent but no prediction/annotation is provided (#987) fix(#800): limit number of metadata fields (#993) docs: improve annotate records section in web app reference (#985) fix(#844) Keep header layout when errors occurred in dataset view (#992) fix(#974): display the dropdown in the last record of the scroll (#986) refactor: compute common aggregations one by one (#990) feat(#953): add additional metrics to `LabelModel.score` method (#979) refactor(rules): using labeling rules management with vuex store (#878) feat(#955): add default for `rules` in WeakLabels (#976) ...
frascuchon
pushed a commit
that referenced
this pull request
Feb 2, 2022
* feat(app): using vuex store for labeling rules * fix lint * fix merge conflict * fix initialize * remove description param * fix rebase conflict * fix "Save rule" condition * calc precision average any rule has not precision * fix rebase conflict * set field for search rule * fix lint * clean unused data * remove unused data * get updated rules when updating summary * fix check if rule exist * get rule info when saving/updating * clean up * set active rule when refreshing page * active label when the query has an associated rule * fix lint * clean unused watch * computed rules condition * fetch if rules are empty * fix: await method and fetch rules * remove --fixed class when destroyed * show 0 for empty rules overall metrics * fix lint * fix: show rule was saved after save a rule * show non labelled rule metrics * refresh rules when updating rules summary * update metrics when rule is saved and other label is selected * fix: show active label when changing query * fix: prevent undefined metrics error Co-authored-by: leiyre <leire@recogn.ai> (cherry picked from commit c40af4f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes app interactions for labeling rules management. Rules and metrics are stored in vuex store and components use the store for communication. Reduce drastically the number of calls done to api server and improve overall performance.
@leiyre take a look carefully since a lot of changes was made.