feat: allow unsupported multi_ack capability #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohankmr414
force-pushed
the
multi-ack
branch
2 times, most recently
from
9f7bf04 to
6fb8246
Compare
Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in transport.UnsupportedCapabilities. The initial clone operations require a full download of the repository, and therefore those unsupported capabilities are not as crucial, so by removing them from that list allows for the first clone to work successfully. Additional fetches will yield issues, therefore to support that repository users have to work from a clean clone until those capabilities are fully supported. Commits and pushes back into the repository have also been tested and work fine. This change adds an example for cloning Azure DevOps repositories. Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
|
cc: @sarabala1979 |
|
Note: the upstream commit author has GPG key settings enforced to his GitHub account (see here), so @rohankmr414 is making this change as a verified commit on the argoproj-labs/go-git fork. @sarabala1979 can we get your approval/ merge on this today? |
|
closing in favor of #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in
transport.UnsupportedCapabilities.The initial clone operations require a full download of the repository, and therefore those unsupported capabilities are not as crucial, so removing them from that list allows for the first clone to work successfully.
Additional fetches will yield issues, therefore to support that repository users have to work from a clean clone until those capabilities are fully supported. Commits and pushes back into the repository have also been tested and work fine.
This change adds an example for cloning Azure DevOps repositories.