Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helm --set-file support #2751

Closed
tomcruise81 opened this issue Nov 21, 2019 · 3 comments
Closed

Add helm --set-file support #2751

tomcruise81 opened this issue Nov 21, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@tomcruise81
Copy link
Contributor

Summary

With helm/helm#3758, helm added the ability to import files via the --set-file argument. This allows files outside of the chart directory to be referenced and used via a chart.

Motivation

We utilize an enterprise-wide chart that has extensive vetted logic. The chart is provided with a values,yaml file and additionally with config map and secrets files via the helm --set-file argument. These are application specific and housed in an external config repository (Spring Cloud Config).

Proposal

This should be implemented in a manner similar to #2078.
@tomcruise81 tomcruise81 added the enhancement New feature or request label Nov 21, 2019
@tomcruise81 tomcruise81 mentioned this issue Nov 21, 2019
Merged
@stale
Copy link

stale bot commented Jan 27, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@tomcruise81
Copy link
Contributor Author

This is still relevant. The pull request is waiting on review by @alexmt.

@alexmt
Copy link
Collaborator

alexmt commented Jan 29, 2020

Fixed by #2752. Thank you @tomcruise81 !

@alexmt alexmt closed this as completed Jan 29, 2020
cardoe added a commit to cardoe/argo-cd that referenced this issue Apr 12, 2024
@cardoe
docs: document helm fileParameters / helm-set-file
5786c64 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#12508 aims to remove this limitation so the warning
can probably be removed with that.
cardoe added a commit to cardoe/argo-cd that referenced this issue Apr 12, 2024
@cardoe
docs: document helm fileParameters / helm-set-file
f50c0a5 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#12508 aims to remove this limitation so the warning
can probably be removed with that.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe cardoe mentioned this issue Apr 12, 2024
Merged
14 tasks
cardoe added a commit to cardoe/argo-cd that referenced this issue Apr 17, 2024
@cardoe
docs: document helm fileParameters / helm-set-file
4ebc9dd 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#12508 aims to remove this limitation so the warning
can probably be removed with that.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe added a commit to cardoe/argo-cd that referenced this issue Apr 25, 2024
@cardoe
docs: document helm fileParameters / helm-set-file
e44e9dc 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#17941 aims to remove this limitation so the warning
will be adjusted to mention the version that lands that support.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe added a commit to cardoe/argo-cd that referenced this issue Apr 25, 2024
@cardoe
docs: document helm fileParameters / helm-set-file
eb5c364 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#17941 aims to remove this limitation so the warning
will be adjusted to mention the version that lands that support.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
crenshaw-dev pushed a commit that referenced this issue Apr 25, 2024
@cardoe
docs: document helm fileParameters / helm-set-file (#17822)
0f11dfb 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from #2751. Added a note about #13220 so
users are aware. #17941 aims to remove this limitation so the warning
will be adjusted to mention the version that lands that support.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
mkieweg pushed a commit to mkieweg/argo-cd that referenced this issue Jun 11, 2024
@cardoe @mkieweg
docs: document helm fileParameters / helm-set-file (argoproj#17822)
f5fea00 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#17941 aims to remove this limitation so the warning
will be adjusted to mention the version that lands that support.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this issue Jun 16, 2024
@cardoe @Hariharasuthan99
docs: document helm fileParameters / helm-set-file (argoproj#17822)
e519e11 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#17941 aims to remove this limitation so the warning
will be adjusted to mention the version that lands that support.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexmt @tomcruise81