feat(ui): Improve UX when filtering applications (#4403) #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetchel
changed the title
|
|
tetchel
force-pushed
the
improveAppsFilter
branch
3 times, most recently
from
4c6f801
to
ffad846
Compare
tetchel
changed the title
- When application filters are active, show a badge with # filters and a button to clear them - When no matching applications are found, provide a button to clear filters - Styling updates to application filters UI Signed-off-by: Tim Etchells <tetchell@redhat.com>
tetchel
force-pushed
the
improveAppsFilter
branch
from
ffad846
to
3cddf22
Compare
alexmt
requested changes
Oct 28, 2020
| <i | ||
| className='fa fa-times' | ||
| onClick={() => { | ||
| AppsListPreferences.clearFilters(this.props.pref); |
There was a problem hiding this comment.
I've reproduced a bug.
- Navigate to the applications list
- Add project filter
- Click "Clear filters"
Projects tags input control keep showing the selected project. I think this is an old bug in https://github.com/argoproj/argo-cd/blob/master/ui/src/app/shared/components/tags-input/tags-input.tsx
getDerivedStateFromProps() handler is missing and component does not support changing input
There was a problem hiding this comment.
I believe I've fixed it - I should have noticed that one when testing.
Signed-off-by: Tim Etchells <tetchell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Etchells tetchell@redhat.com
Checklist:
Fixes #4403