Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show Application as degraded in case of Git repo errors and initial sync #10334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Aug 15, 2022

Fixes #10330

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • [n/a] Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

…tial sync

Signed-off-by: Andreas Sommer <andreas.sommer87@googlemail.com>
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6756a5f) 46.13% compared to head (3347c02) 46.16%.
Report is 1769 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10334      +/-   ##
==========================================
+ Coverage   46.13%   46.16%   +0.03%     
==========================================
  Files         228      228              
  Lines       27961    27967       +6     
==========================================
+ Hits        12900    12912      +12     
+ Misses      13315    13311       -4     
+ Partials     1746     1744       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Issue/PR had no activity for a long time and should be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health and sync status overview does not cover fatal error conditions (example: wrong Git repo or path)
2 participants