Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update redis lib version #10674

Closed
wants to merge 4 commits into from
Closed

chore: update redis lib version #10674

wants to merge 4 commits into from

Conversation

emirot
Copy link
Contributor

@emirot emirot commented Sep 22, 2022

I've seen in https://github.com/go-redis/redis

If you are using Redis 7, install go-redis/v9:

go get github.com/go-redis/redis/v9

Argocd is using redis 7 https://github.com/argoproj/argo-cd/blob/master/manifests/install.yaml#L10195 but the previous lib version is used github.com/go-redis/redis/v8 in argo.

I don't know about the change in redis and the incompatibilities it might or may not bring.

Signed-off-by: nolan-emirot <nolan.emirot@workday.com>
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.75%. Comparing base (02bf903) to head (97c53f5).
Report is 2558 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10674   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         236      236           
  Lines       28527    28527           
=======================================
  Hits        13053    13053           
  Misses      13669    13669           
  Partials     1805     1805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nolan-emirot added 3 commits September 22, 2022 18:16
Signed-off-by: nolan-emirot <nolan.emirot@workday.com>
Signed-off-by: nolan-emirot <nolan.emirot@workday.com>
@crenshaw-dev
Copy link
Member

@emirot it looks like the latest v9 release is still marked beta. Is it meant for production use?

@emirot
Copy link
Contributor Author

emirot commented Sep 23, 2022

@emirot it looks like the latest v9 release is still marked beta. Is it meant for production use?

Asked in redis/go-redis#2220

@emirot emirot closed this by deleting the head repository Sep 24, 2022
@emirot emirot mentioned this pull request Jan 31, 2023
10 tasks
@emirot emirot mentioned this pull request Mar 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants