Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use react link to route to relative deep-link path #13529

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ashutosh16
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@ashutosh16 ashutosh16 marked this pull request as ready for review May 12, 2023 20:14
@ashutosh16 ashutosh16 changed the title feat: Link the deeplink path to relative and absolute link feat: use react link to route to relative deep-link path May 12, 2023
@ashutosh16 ashutosh16 changed the title feat: use react link to route to relative deep-link path fix: use react link to route to relative deep-link path May 12, 2023
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a3a81c) 49.22% compared to head (45f01ea) 49.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13529   +/-   ##
=======================================
  Coverage   49.22%   49.22%           
=======================================
  Files         248      248           
  Lines       42830    42830           
=======================================
  Hits        21084    21084           
  Misses      19648    19648           
  Partials     2098     2098           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdsoumya gdsoumya requested a review from rbreeze May 28, 2023 04:23
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but will get @rbreeze to approve it too before merging.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crenshaw-dev crenshaw-dev changed the title fix: use react link to route to relative deep-link path fix(ui): use react link to route to relative deep-link path Jun 16, 2023
@crenshaw-dev crenshaw-dev merged commit 8f63ba3 into argoproj:master Jun 16, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…#13529)

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…#13529)

Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants