feat: Allow 'both' option for uibannerposition #14623

Jneville0815 · 2023-07-20T15:51:10Z

With this update, the uibannerposition attribute now supports the value both, enabling the display of the banner on both the top and bottom of the page simultaneously. This enhancement eliminates the need to choose between top or bottom placement, providing users with more flexible banner positioning options.

codecov · 2023-07-20T16:06:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26264b8) 49.55% compared to head (4d78ae5) 49.55%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #14623   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       46891    46891           
=======================================
  Hits        23236    23236           
  Misses      21374    21374           
  Partials     2281     2281

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashutosh16 · 2023-08-22T17:13:26Z

@Jneville0815 Could you please provide a video or screenshot of the change. Also, the documentation would need to be updated.
it is unclear to me if this is the only option available and the banner will be displayed both at the top and the bottom simultaneously. If that is the case, we should not remove the option to display banners only on the top or bottom of the ui.

Jneville0815 · 2023-08-23T13:23:23Z

The options for top only and bottom only still work the same as they did prior to this change. Here's a screenshot of both banners displayed at once:

Should I go ahead and update the documentation?

ashutosh16 · 2023-08-24T14:25:49Z

@Jneville0815 It would be helpful if you could add the documentation. thx

Jneville0815 · 2023-08-26T14:06:37Z

@ashutosh16 do you know where all it will need to be updated?

ashutosh16 · 2023-09-28T23:01:08Z

@Jneville0815 I apologize for the delay; I will take active steps to get the feedback on this PR. Here you can add the docs

Jneville0815 · 2023-09-30T19:35:14Z

docs

@ashutosh16 np! Just updated the docs. Let me know if anything else is needed

…rgoproj#14629) Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…goproj#14641) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.7.0...v5.8.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…spaces are configured (argoproj#13976) * fix: Add failing test for webhooks in all namespaces This adds a failing test that properly exercises this functionality over all namespaces. The issue with the code that is under test is that it does not pass the namespace correctly to the patch of the application, resulting in the patch not taking place in the correct namespace Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: queue webhook refresh for apps in all namespaces This passes the test in the previous commit, to ensure that webhooks correctly refresh applications across all namespaces. Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> * fix: Use existing NamespacedName type Use the existing type instead of a custom type Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> --------- Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

… Cannot find end tag="}}"(argoproj#14227) (argoproj#14651) * ApplicationSet bug fix Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> * Update applicationset/utils/utils_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

… 15 pods (argoproj#14590) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

Signed-off-by: daftping <21245083+daftping@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…rgoproj#14553) * chore: Print in-cluster svr addr disabled warning when server starts Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * fix: mock Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * no interface change Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…rgoproj#14424) Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…roj#14273) * fix(controller): log failed attempts to update operation state Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * new package name Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * Update controller/appcontroller_test.go Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…14530) Signed-off-by: mmerrill3 <jjpaacks@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…argoproj#14680) * fix: manifest generation error with null annotations Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix test Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix unit tests Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

Signed-off-by: Zechun Chen <zechun.chen@daocloud.io> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…goproj#11237) Signed-off-by: ylxianzhe <ylxianzhe@outlook.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

* 9353: Restrict scm provider urls Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Enforce restriction Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix after review Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix units tests Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Code review, update comment 2 Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Remove doc issues Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e goTemplate Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> * 9353: Fix e2e pullRequestGenerator Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> --------- Signed-off-by: gmuselli <geoffrey.muselli@gmail.com> Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…goproj#14744) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.8.0...v5.8.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…argoproj#14746) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.305...v1.44.309) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

* fix: display valuesobject if set With argoproj#11538 we now have the ability to set helm values as an object instead of a string, but we also need to be able to correctly display it in the UI if it is set. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set valuesobject on save If `valuesObject` is present, set it to the value of `input.spec.source.helm.values` on save, as an unmarshaled json string. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: set `helm.values` to empty string on save If `valuesObject` exists, set `input.spec.source.helm.values` to an empty string once `valuesObject` has been unmarshalled from the values input. This is to prevent unnecessary duplication of the values. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: deep clone app This is so that we can conditionally set `source.helm.values` without inadvertently affecting other parts of the app. Only when the edit button is pressed do we toggle `source.helm.values`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: eslint Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

Signed-off-by: felix <felix@psy-coding.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

…rgoproj#15659) (argoproj#15660) * fix(appset): don't emit k8s events for unchanged application events and move that scenario to debug logging level Signed-off-by: Eric Blackburn <eblackburn@indeed.com> * Retrigger CI pipeline Signed-off-by: Eric Blackburn <eblackburn@indeed.com> * Retrigger CI pipeline Signed-off-by: Eric Blackburn <eblackburn@indeed.com> --------- Signed-off-by: Eric Blackburn <eblackburn@indeed.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>