feat(appset): get latest protected tag from gitlab api #15886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #15886 +/- ##
==========================================
- Coverage 49.51% 49.47% -0.05%
==========================================
Files 269 269
Lines 46990 47032 +42
==========================================
Hits 23269 23269
- Misses 21437 21478 +41
- Partials 2284 2285 +1
☔ View full report in Codecov by Sentry. |
crenshaw-dev
changed the title
crenshaw-dev
requested changes
Oct 10, 2023
Demch1k
force-pushed
the
latest-tag-for-gitlab-scm-generator
branch
2 times, most recently
from
74b9b96
to
ad82bdf
Compare
|
@crenshaw-dev Could you please take a look? |
|
@crenshaw-dev Could you please take a look on this PR when you will have free time. |
|
@crenshaw-dev any updates? |
Demch1k
force-pushed
the
latest-tag-for-gitlab-scm-generator
branch
from
ecaebb6
to
5bf6359
Compare
added 9 commits
November 7, 2023 09:48
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Signed-off-by: Ivan Sokoryan <i.sokoryan@robo.cash>
Demch1k
force-pushed
the
latest-tag-for-gitlab-scm-generator
branch
from
5bf6359
to
ca2b78c
Compare
|
Could someone take a look on this PR please? |
ishitasequeira
requested changes
Nov 16, 2023
| return []gitlab.Tag{}, nil | ||
| } | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Can we add more details to the error here?
Comment on lines
+211
to
+213
| if resp != nil && resp.StatusCode == http.StatusNotFound { | ||
| return []gitlab.Tag{}, nil | ||
| } |
There was a problem hiding this comment.
Do we get an err when receiving 404s? If not, can we check for err != nil first?
Comment on lines
+234
to
+238
| for _, tag := range tags { | ||
| if tag.Protected { | ||
| return tag.Name, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we have more than one protected tags? If yes, should we return the list here?
| @@ -110,6 +112,7 @@ spec: | |||
| * `topic`: filter projects by topic. A single topic is supported by Gitlab API. Defaults to "" (all topics). | |||
| * `tokenRef`: A `Secret` name and key containing the GitLab access token to use for requests. If not specified, will make anonymous requests which have a lower rate limit and can only see public repositories. | |||
| * `insecure`: By default (false) - Skip checking the validity of the SCM's certificate - useful for self-signed TLS certificates. | |||
| * `latestProtectedTag`: Obtain latest protected tag to use it in deployments. | |||
There was a problem hiding this comment.
Can we add the default value here?
| @@ -496,6 +496,8 @@ type SCMProviderGeneratorGitlab struct { | |||
| IncludeSharedProjects *bool `json:"includeSharedProjects,omitempty" protobuf:"varint,7,opt,name=includeSharedProjects"` | |||
| // Filter repos list based on Gitlab Topic. | |||
| Topic string `json:"topic,omitempty" protobuf:"bytes,8,opt,name=topic"` | |||
| // Obtain latest protected tag from GitLab project. Default to "false" | |||
| LatestProtectedTag bool `json:"latestProtectedTag,omitempty" protobuf:"varint,9,opt,name=latestProtectedTag"` | |||
There was a problem hiding this comment.
Would it be better to rename this to FetchLatestProtectedTag?
|
Are there any plans to accept this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
This Pull Request add feature to get latest protected tag from GitLab API for SCM provider to use it with ApplicationSet.
In our company we are using simple GitFlow to deploy our applications. It means that we have 3 stages (review/stage/production). On the last stage of deploying we use lastest protected tag in gitlab to deploy our application to production.
We want to use ApplicationSet but without tags it will be not possible to implement it in our GitFlow.
What do you think about this PR? It it possible to have it in the future release or could someone do it in better way?
I have tested it locally and in our test ArgoCD installation. It works great.
Checklist: