Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Excessive HTTP requests when navigating in list view - 17756 #17757

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix: Excessive HTTP requests when navigating in list view - 17756 #17757

merged 2 commits into from
Apr 16, 2024

Conversation

adberger
Copy link
Contributor

@adberger adberger commented Apr 5, 2024 •
edited
Loading

Fixes #17756

As for tree view renderResourceMenu now should only get triggered when clicking on the resource menu in the list view as well.

Please be careful about the review since this is my first contribution.
If you want to backport it, is up to you to decide.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@adberger adberger requested review from a team as code owners April 5, 2024 21:08
@adberger
Copy link
Contributor Author

adberger commented Apr 9, 2024

@ashutosh16 Do I need to do anything else for a reviewer to look into it?

@adberger @ashutosh16
fix: Excessive HTTP requests when navigating in list view
6106dfa 
Signed-off-by: Adrian Berger <adria.berger94@gmail.com>
@ashutosh16
Copy link
Contributor

LGTM

Screen.Recording.2024-04-09.at.22.46.56.mov

@ashutosh16
Copy link
Contributor

@ishitasequeira Changes look to me, Can you take a second look at the changes?

pasha-codefresh
pasha-codefresh approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your first contribution!

@pasha-codefresh pasha-codefresh merged commit e12fae8 into argoproj:master Apr 16, 2024
23 checks passed
@adberger adberger deleted the fix/excessive-http-requests-in-list-view branch April 16, 2024 11:24
@adberger
Copy link
Contributor Author

@pasha-codefresh Where do I see starting from which version this change will be active?

mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@adberger @pasha-codefresh @mkieweg
fix: Excessive HTTP requests when navigating in list view (argoproj#1…
a4167f8 
…7757)

Signed-off-by: Adrian Berger <adria.berger94@gmail.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@adberger @pasha-codefresh @Hariharasuthan99
fix: Excessive HTTP requests when navigating in list view (argoproj#1…
94f6f5d 
…7757)

Signed-off-by: Adrian Berger <adria.berger94@gmail.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh approved these changes

@ashutosh16 ashutosh16 ashutosh16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive HTTP requests and therefore API calls when navigating in list view
3 participants
@adberger @ashutosh16 @pasha-codefresh