Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document possibility to specify request timeout in plugin generator #17872

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

isihu
Copy link
Contributor

@isihu isihu commented Apr 17, 2024

In the plugin generator code, I've found the possibility to manually set the timeout for a request to a plugin generator.
This feature isn't documented, though. With this PR it is.

Signed-off-by: isihu <62214125+isihu@users.noreply.github.com>
@isihu isihu requested review from a team as code owners April 17, 2024 12:32
@isihu isihu changed the title Document possibility to specify request timeout in plugin generator docs: document possibility to specify request timeout in plugin generator Apr 17, 2024
Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasha-codefresh pasha-codefresh merged commit 60f3332 into argoproj:master Apr 17, 2024
23 of 24 checks passed
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
…rgoproj#17872)

Signed-off-by: isihu <62214125+isihu@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
…rgoproj#17872)

Signed-off-by: isihu <62214125+isihu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants