Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade controller-gen from 0.4.1 to 0.14.0 #17893

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

crenshaw-dev
Copy link
Member

controller-gen versions before 0.14.0 suffer from nil reference errors with go versions >= 1.22.

Going ahead and bumping controller-gen to unblock a 1.22 upgrade.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev requested review from a team as code owners April 18, 2024 21:14
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit 33f5714 into argoproj:master Apr 18, 2024
27 checks passed
@crenshaw-dev crenshaw-dev deleted the upgrade-controller-gen branch April 19, 2024 00:21
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants