chore(deps): upgrade argo-ui, including breaking changes

[agilgur5]

Motivation

As requested in argoproj/argo-ui#535 (review)
Upgrade to the latest version of argo-ui, resolve breakage, and fix a bug in CD via the upgrade

Modifications

• upgrade to https://github.com/argoproj/argo-ui/tree/a7b01f9f009aa9161da21f450b5aab2f0732eb74

• Per refactor(deps)!: remove moment dep and usage argo-ui#535, moment is no longer used internally by argo-ui, so change Ticker usage to account for this

  • CD should also remove the moment library for as it is deprecated. see also the downstream PR and Workflows PRs (refactor(ui): replace moment-timezone with native Intl argo-workflows#12097, refactor(deps): remove moment dep and usage argo-workflows#12611)

• Per fix!: remove deprecated durationMs prop argo-ui#577, the Duration component had an erroneously named durationMs prop, which has now been changed to durationS

Fixes #16745 via argoproj/argo-ui#546, which is included in this upgrade

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• [n/a] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• [no] Does this PR require documentation updates?
• [n/a] I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• [n/a] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• [n/a] My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• [n/a] Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[agilgur5]

Ah type-checking failed as I appear to have forgotten to make durationS / durationMs optional in the types upstream (c.f. argoproj/argo-ui#535 (comment)), woops:

yarn run v1.22.22
$ tsc --noEmit --project ./src/app && eslint
Error: src/app/applications/components/application-deployment-history/application-deployment-history.tsx(43,56): error TS2[7](https://github.com/argoproj/argo-cd/actions/runs/10516846738/job/29139870127?pr=19655#step:7:8)41: Property 'durationS' is missing in type '{ durationMs: number; }' but required in type '{ durationMs: number; durationS: number; }'.
Error: src/app/applications/components/application-deployment-history/application-deployment-history.tsx(55,30): error TS2741: Property 'durationS' is missing in type '{ durationMs: number; }' but required in type '{ durationMs: number; durationS: number; }'.
Error: src/app/applications/components/application-operation-state/application-operation-state.tsx(63,31): error TS2741: Property 'durationS' is missing in type '{ durationMs: number; }' but required in type '{ durationMs: number; durationS: number; }'.

I'll push a workaround here (setting the other to null), but should also fix those types there. Unfortunately can't quite do "one of" in TS though. EDIT: I decided to just remove the now deprecated durationMs in argoproj/argo-ui#577

[crenshaw-dev]

Everything looks good except maybe the sync operation panel. Looks like the duration is missing there.

lmk if you want to test in the Bunnyshell instance, I can send you the credentials.

[agilgur5]

Huh since it already finished, that should've actually short-circuited the changed code here 🤔

lmk if you want to test in the Bunnyshell instance, I can send you the credentials

Yea that would be helpful!

[agilgur5]

Everything looks good except maybe the sync operation panel. Looks like the duration is missing there.

Oh, this is an edge case: it's a 0 second duration apparently. I suppose that's a bug in my refactor; the previous logic did handle 0 on this line, although not sure if it intentionally handled that 😅

I'll throw in another fix in argo-ui then

[agilgur5]

No wait, the new logic (or well, newly switched to logic, the logic itself is still old) handles the 0 case as well. 🤔

[agilgur5]

Oh, I think this will be fixed by argoproj/argo-ui#577 as well; the 0 edge case causes the parameter into formatDuration to be a little wacky due to the backward-compatible ||:

❯ node
Welcome to Node.js v20.6.0.
Type ".help" for more information.
> 0 || undefined
undefined
> 0 || null
null
> 0 || 0
0

And JS doesn't error when doing operations on null or undefined (see also https://www.destroyallsoftware.com/talks/wat), so it actually just returns false for every condition in formatDuration, ending up with an '' result.

The workaround here would be to use 0 for durationMs instead of null, but I'd rather just upgrade to the version after argoproj/argo-ui#577

[agilgur5]

Now that argoproj/argo-ui#577 has been merged, I've updated the code here as well

[crenshaw-dev]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

/bns:start

[crenshaw-dev]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

/bns:deploy

[crenshaw-dev]

Local test checks out, thanks!