Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1940 - Wait for CRD creation during sync process #1999

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Jul 24, 2019

Closes #1940

@alexmt alexmt requested review from jessesuen and alexec July 24, 2019 21:05
controller/sync.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #1999 into master will decrease coverage by 0.03%.
The diff coverage is 53.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
- Coverage   35.94%   35.91%   -0.04%     
==========================================
  Files          89       89              
  Lines       12828    12845      +17     
==========================================
+ Hits         4611     4613       +2     
- Misses       7592     7605      +13     
- Partials      625      627       +2
Impacted Files Coverage Δ
controller/sync.go 65.78% <53.12%> (-2.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5ea7e...897c2d1. Read the comment docs.

@alexmt alexmt added this to the v1.2 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo CD sync might fail to create if app contains CRD and instance of the same CRD
2 participants